refactor: inject forest-server-requester #532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
refactor/move-service-url-getter-to-utils
to
master
November 17, 2020 08:25
jeffladiray
force-pushed
the
refactor/inject-forest-url-requester
branch
from
e1b18a3
to
ff10c55
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
|
||
| return reject(new Error(errorMessages.SERVER_TRANSACTION.UNEXPECTED, error)); | ||
| return reject(new Error(this.errorMessages.SERVER_TRANSACTION.UNEXPECTED, error)); |
There was a problem hiding this comment.
Avoid too many return statements within this function.
|
Code Climate has analyzed commit ff10c55 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 93.7% (49% is the threshold). This pull request will bring the total coverage in the repository to 50.4% (0.1% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist: