Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[-] Technical - Upgrade to babel 7 stable #289

Merged
merged 4 commits into from
Jan 31, 2020
Merged

Conversation

rap2hpoutre
Copy link
Contributor

Pull Request checklist:

  • Write an explicit title for the Pull Request
  • Write changes made in the CHANGELOG.md
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@rap2hpoutre rap2hpoutre self-assigned this Jan 24, 2020
@rap2hpoutre
Copy link
Contributor Author

rap2hpoutre commented Jan 27, 2020

Copy link
Member

@VincentMolinie VincentMolinie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the yarn.lock is not up to date too

@rap2hpoutre
Copy link
Contributor Author

It seems OK

➜  forest-express-mongoose git:(upgrade/babel-7) yarn
yarn install v1.19.1
[1/4] 🔍  Resolving packages...
success Already up-to-date.
✨  Done in 0.32s.
➜  forest-express-mongoose git:(upgrade/babel-7) git status
On branch upgrade/babel-7
Your branch is up to date with 'origin/upgrade/babel-7'.

nothing to commit, working tree clean

@rap2hpoutre
Copy link
Contributor Author

Deleted node_modules, it has been updated 🤔

@rap2hpoutre rap2hpoutre merged commit a07db20 into devel Jan 31, 2020
@rap2hpoutre rap2hpoutre deleted the upgrade/babel-7 branch January 31, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants