Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/SDL Passenger Mode #1

Closed
wants to merge 12 commits into from

Conversation

KhrystynaDubovyk
Copy link

Is related to
https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0119-SDL-passenger-mode.md

This PR is [ready] for review.

Summary
Add API folder; add OnDriverDistraction folder with TRS, UC, accessories

CLA

CLA

@IGapchuk IGapchuk self-requested a review December 7, 2018 12:31
Copy link

@yang1070 yang1070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the proposal

In addition to modifying the notification as shown above, there needs to be an addition to the policy table that feeds into that notification. This way, the OEM can update the ability to allow / disallow this with an update to their policy table.

my understanding is the parameter lockScreenDismissalEnabled is only added to the mobile api, not hmi api. SDL get the value of lockScreenDismissalEnabled from policy.

case2 (an app is not in HMI level NONE)
case 2.1
HMI -> SDL : OnDriverDistraction (state=DD_OFF)
SDL -> Apps : OnDriverDistraction (state=DD_OFF)

case 2.2
HMI -> SDL : OnDriverDistraction (state=DD_ON)
policy has lockScreenDismissalEnabled as true
SDL -> Apps : OnDriverDistraction (lockScreenDismissalEnabled=true)

case 2.3
HMI -> SDL : OnDriverDistraction (state=DD_ON)
policy has lockScreenDismissalEnabled as false
SDL -> Apps : OnDriverDistraction (lockScreenDismissalEnabled=false)

@KhrystynaDubovyk
Copy link
Author

@yang1070, please advise,

  • should we add lockScreenDismissalEnabled to module_config in policies (instead of HMI_API) ?
  • should lockScreenDismissalEnabled param be settable?

@KhrystynaDubovyk
Copy link
Author

@yang1070, please see the updates
7558b9b
631509a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants