Sdl passenger mode unit tests #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuxoftAKutsan
requested review from
AByzhynar,
AKalinich-Luxoft,
BSolonenko,
IGapchuk,
mked-luxoft,
mkorniichuk and
oivin-luxoft
BSolonenko
approved these changes
Jan 10, 2019
IGapchuk
approved these changes
Jan 10, 2019
AKalinich-Luxoft
approved these changes
Jan 10, 2019
| @@ -1794,24 +1794,36 @@ TEST_F(HMICommandsNotificationsTest, OnDriverDistractionNotificationEmptyData) { | |||
| CreateCommand<hmi::OnDriverDistractionNotification>(message); | |||
|
|
|||
| EXPECT_CALL(app_mngr_, set_driver_distraction_state(state)); | |||
| EXPECT_CALL(app_mngr_, applications()).WillOnce(Return(applications_)); | |||
| ON_CALL(app_mngr_, GetPolicyHandler()) | |||
There was a problem hiding this comment.
@LuxoftAKutsan I would suggest you to extract these lines to a separate helper function as they are duplicated in at least 3 places
There was a problem hiding this comment.
@AKalinich-Luxoft hmi_notifications_test.cc contains a lot of other tests, not related to the task. Most of them have different basic expectations. Helper function would be to specific to all this variety.
AByzhynar
requested changes
Jan 10, 2019
| ON_CALL(app_mngr_, GetPolicyHandler()) | ||
| .WillByDefault(ReturnRef(mock_policy_handler_interface_)); | ||
| ON_CALL(mock_policy_handler_interface_, LockScreenDismissalEnabledState()) | ||
| .WillByDefault(Return(utils::OptionalVal<bool>(true))); |
There was a problem hiding this comment.
@LuxoftAKutsan Why did not you use typedef in this translation unit like you did in other one?
mkorniichuk
approved these changes
Jan 10, 2019
AByzhynar
approved these changes
Jan 11, 2019
LuxoftAKutsan
requested review from
LitvinenkoIra
and removed request for
LitvinenkoIra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests fix after implementation smartdevicelink#2134
Additional unit test for SDL passenger mode
lockScreenDismissalEnabledaddedFixed bug : crash on empty optional copy
This PR is ready for review.