180 bug insulate entry classes within alignedtextgrid instances from the global class #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Still needs tests. @chrisbrickhouse I think if this is merged and published, it should resolve your problem with fave-syllabify: Forced-Alignment-and-Vowel-Extraction/fave-syllabify#5 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #181 +/- ##
==========================================
- Coverage 91.33% 89.53% -1.80%
==========================================
Files 14 14
Lines 1269 1319 +50
==========================================
+ Hits 1159 1181 +22
- Misses 110 138 +28 ☔ View full report in Codecov by Sentry. |
chrisbrickhouse
requested changes
May 2, 2024
JoFrhwld
deleted the
180-bug-insulate-entry-classes-within-alignedtextgrid-instances-from-the-global-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will clone entry classes upon creation of an AlignedTextGrid, thus insulating any changes made to those entry classes from the global environment, or other AlignedTextGrid objects.