Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use guidelines for WPF render #71

Merged
merged 1 commit into from
Mar 12, 2017
Merged

Conversation

ForNeVeR
Copy link
Owner

@ForNeVeR ForNeVeR commented Mar 11, 2017

Fixes #50.

That's my another try to fix that long-standing issue. That time I've finally read the documentation (thanks @Atomosk for pointing me to the tutorial page Draw lines excactly on physical device pixels).

That time, we have no obvious regressions for any of the scale settings, so I think that's definitely a way to go. Check the comparison (clickable):

image

(The fonts are notably clearer now, and even without turning off the font antialiasing settings!)

These changes supersedes the changes in #52 and in the branches bugfix/50-blur and bugfix/50-blur-alternate; gonna to delete them after the merge.

@ForNeVeR ForNeVeR self-assigned this Mar 11, 2017
@ForNeVeR ForNeVeR requested review from alexreg and gsomix March 11, 2017 17:06
@@ -1,4 +1,4 @@
using System;
using System;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check what's going on with that line. I've edited it with VS2017 with the default settings; probably it has changed the BOM in the file.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it has been added the BOM. We shouldn't care.

@ForNeVeR ForNeVeR force-pushed the feature/50-deblur-with-guidelines branch from 7bfd689 to 0d4fbca Compare March 11, 2017 17:11
@alexreg
Copy link
Collaborator

alexreg commented Mar 12, 2017

Ah, this is great news!

Just a note: I'm not sure how you're deleting the branches, but you still seem to be leaving Git refs around (git branch -r should verify this). I know you haven't merged yet, but this is the case for some old branches/refs, it seems.

@ForNeVeR
Copy link
Owner Author

ForNeVeR commented Mar 12, 2017

@alexreg

Just a note: I'm not sure how you're deleting the branches, but you still seem to be leaving Git refs around (git branch -r should verify this). I know you haven't merged yet, but this is the case for some old branches/refs, it seems.

I just haven't deleted the branches yet :)

Usually I tend to keep my repositories in a cleaner state, but that time we have much work on issue #50, and I didn't want to delete any branches that could be useful until the issue is resolved.

I've verified and all the branches listed by git branch -r at the current moment are active, namely:

@ForNeVeR ForNeVeR merged commit 0d4fbca into master Mar 12, 2017
@ForNeVeR
Copy link
Owner Author

Thanks for the review, guys!

@torfranz
Copy link

Hi, although this is much better than before I still think there is blurred output especially on horizontal lines. When you look at the equal signs, both are still blurry in default scale 20. Vertical lines and text are pretty crisp at this scale level. Thanks for all the efforts though!

@ForNeVeR
Copy link
Owner Author

ForNeVeR commented Mar 13, 2017

@torfranz could you please post a screenshot? I'm looking to improve the resulting image, but I'd like to agree on the formula pieces that have the worst rendering quality for now.

@torfranz
Copy link

image

Please note the blurred horizontal lines on the equal sign.

@ForNeVeR
Copy link
Owner Author

Thanks for elaboration. I can see the problem; I'll convert that into a new issue in the evening.

@alexreg
Copy link
Collaborator

alexreg commented Mar 13, 2017

There are still problems on the vertical lines too (of the radical sign), from that image. I didn't notice them when testing on my machine, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve blurred output
4 participants