-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jlm_msam10.ttf and somme symbol it contains #400
Conversation
According to the license information, it seems to use OFL which should be pretty okay. |
@Orace, how did you generate I fear that would be covered by GPL :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The font files seems pretty okay (we'll need to just copy and redistribute the OFL text with us, I think), though the GPLd data inclusion doesn't look good. If you did take the data from JLaTeXMath, then I fear I'll have to put veto on merging of this until we figure out how to regenerate it without GPL involvement :(
(Which have to be possible, yet have never been demostrated.)
I did copy the data from the JLaTeXMath repository, I will search for a solution, ideally it should be extracted from the font itself on the fly. |
Some known information is documented in https://github.com/ForNeVeR/xaml-math/blob/master/docs/prepare-font.md But, sadly, I don't know everything, yet :( |
I'd like to emphasize that I value your efforts very much! But we've already had some problems with GPL data and sources relicensing in the past, and we want to make the library available under the MIT license. So, for the best of our users, and to follow all the GPL requirements (which, I should add, we of course respect), we have to avoid distributing GPL code and data with the library. Earlier, I had a feeling that we almost have everything to regenerate the data, and there are only a few steps left before we'll be able to automate that and get rid even of the data we've copied from a GPL project (and then legally relicensed, with the permission of the maintainers). |
adda323
to
30fe4af
Compare
Wow, that's a solid research. I'll take some time to think about it. |
@Orace, after a little debugging, I was able to crack down this particular problem. Distance from one symbol to another relies on the symbol kind: for example, an equals sign has a "relative operator" kind and thus will be enclosed with some space. You've set certain symbols such as <Symbol name="ulcorner" type="open"/>
<Symbol name="urcorner" type="close"/>
<Symbol name="llcorner" type="open"/>
<Symbol name="lrcorner" type="close"/> |
Anyway, I guess we can start from the definitions you were able to generate using this tool. It still lacks some details (such as |
Alright, anyway: I suggest you to take another look at the current symbol list and what should have which kind (or maybe dig down into the TeX sources to find out the real symbol kind mappings, though that's optional). I am still not entirely happy with our character data generator, but that's an impressive start. After that, I'll manage the dull details of licensing and documentation, and that's good to be merged. |
- Add some symbols it contains - Add an example in WpfMath.Example - Add TTFMetrics tool - Improve WpfMath.Example editor
@ForNeVeR, I used the The special cases (for which the type seems obvious, but I have checked jlatexmath) are:
|
163d24c
to
8aa40c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your help on these issues!
This commit add a new font
jlm_msam10.ttf
copied from jlatexmath .It adds support for:
TODO
TTFMetrics
usage