WPF support for .NET Core 3.0 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ForNeVeR
force-pushed
the
pull/219
branch
2 times, most recently
from
efd792e to
06701e0
Compare
This was referenced Dec 10, 2019
The project won't build on .NET Core 3.0 SDK because the F# compiler there is slightly outdated and won't build a code fragment `member private _.`
This is necessary while there's no support for .NET Core 3.1 in the default image.
|
@hez2010, thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #219, but I had to create a new PR because I want to force-push some infrastructure upgrades and I have no permission to force-push to the
masterbranch of @hez2010's repository.So, we'll migrate from Sunburst SDK to a .NET Core native one, but will still support .NET 4.5.2+ with .NET Core 3.0.
I had to remove
System.ValueTuplepackage because of the troubles it creates for multitarget projects.Also, I had to fix #217 by introducing more robust
doubleformatter because of differences between frameworks we can't not tolerate (because both the frameworks use the same test data).Appveyor will use
Visual Studio 2019 Previewimage for now, because currentVisual Studio 2019has no .NET Core 3.1 support yet. We'll likely replace it withVisual Studio 2019later, when they'll update their image.TODO
TODOs#nullableeverywhere in the C# project