Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#59 Support for Unicode delimiters. #160

Merged
merged 11 commits into from
Jan 3, 2020
Merged

Conversation

B3zaleel
Copy link
Contributor

@B3zaleel B3zaleel commented Sep 22, 2018

Delimiter symbols that are included in a given mathematical font can now be properly rendered with the \left and \right commands. For example; \left\lbag \frac{4-x}{7x^3}\right\rbag.

TODO (Friedrich):

  • Fix the unit tests
  • Fix all the remaining issues (see the comments below)
  • Perform the final review again

Closes #59.

@Happypig375

This comment has been minimized.

@B3zaleel

This comment has been minimized.

@ForNeVeR ForNeVeR self-assigned this Sep 1, 2019
@ForNeVeR ForNeVeR self-requested a review January 3, 2020 06:54
Renamed "*Element*" to "*Argument*"  ("ReadElementGroup" is now named as "ReadArgumentGroup".
The "ReadArgumentGroup" can now read an escape sequence of letters or a character(this is extremely useful for the "*\\left*" and "*\\right*" commands, etc).
It also fixes issue ForNeVeR#158.
@ForNeVeR

This comment has been minimized.

@ForNeVeR
Copy link
Owner

ForNeVeR commented Jan 3, 2020

@B3zaleel, thanks a lot for your work! I approve this PR in principle.

I've rebased it on top of today's master, and will make some review notes and fix them all myself. After that, the PR will be ready for merge.

src/WpfMath/TexFormulaParser.cs Outdated Show resolved Hide resolved
src/WpfMath/TexFormulaParser.cs Outdated Show resolved Hide resolved
src/WpfMath/TexFormulaParser.cs Outdated Show resolved Hide resolved
src/WpfMath/TexFormulaParser.cs Outdated Show resolved Hide resolved
src/WpfMath/TexFormulaParser.cs Outdated Show resolved Hide resolved
src/WpfMath/TexFormulaParser.cs Outdated Show resolved Hide resolved
src/WpfMath/TexFormulaParser.cs Outdated Show resolved Hide resolved
@ForNeVeR

This comment has been minimized.

@ForNeVeR

This comment has been minimized.

@ForNeVeR

This comment has been minimized.

src/WpfMath/TexFormulaParser.cs Outdated Show resolved Hide resolved
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now everything is good. Thanks for the initial implementation, @B3zaleel!

@ForNeVeR ForNeVeR merged commit 1235259 into ForNeVeR:master Jan 3, 2020
@B3zaleel B3zaleel deleted the patch-7 branch March 2, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make delimiters great again
3 participants