Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color support #142

Merged
merged 40 commits into from
Oct 20, 2019
Merged

Color support #142

merged 40 commits into from
Oct 20, 2019

Conversation

ForNeVeR
Copy link
Owner

@ForNeVeR ForNeVeR commented Jul 16, 2018

Changes extracted from #138 by @B3zaleel.

Closes #165.

TODO:

  • leave only the original commands (\color and \colorbox)
  • fix the failing unit tests
  • think about the accepted color formats
    • check if any existing TeX distributions have something like that
  • write the documentation for the new color input
  • add tests for the new input
  • fix the implementation according to the tests
  • make sure it's robust enough so the new color parsers could be added easily
  • review all the comments below
  • add tests for double/integer parse errors in the color parsers (all should throw TexParseExceptions)
  • add tests for negative / too big values for all the numbered models (should also throw TexParseExceptions)
  • make sure the corresponding infrastructure and helper classes are public
  • review all the code one final time

B3zaleel added 4 commits June 29, 2018 17:25
Added support for parsing a color string representation with the "color" command.
Added the converter for the "colorbox".
Fixed some minor issues with the boolean checks
@ForNeVeR ForNeVeR self-assigned this Jul 16, 2018
src/WpfMath/TexFormulaParser.cs Outdated Show resolved Hide resolved
src/WpfMath/TexFormulaParser.cs Outdated Show resolved Hide resolved
src/WpfMath/TexFormulaParser.cs Outdated Show resolved Hide resolved
src/WpfMath/TexFormulaParser.cs Outdated Show resolved Hide resolved
src/WpfMath/TexFormulaParser.cs Outdated Show resolved Hide resolved
src/WpfMath/UserDefinedColorParser.cs Outdated Show resolved Hide resolved
src/WpfMath/UserDefinedColorParser.cs Outdated Show resolved Hide resolved
src/WpfMath/UserDefinedColorParser.cs Outdated Show resolved Hide resolved
src/WpfMath/UserDefinedColorParser.cs Outdated Show resolved Hide resolved
src/WpfMath/UserDefinedColorParser.cs Outdated Show resolved Hide resolved
@ForNeVeR
Copy link
Owner Author

@B3zaleel if you're going to make any changes — please create a new branch based on feature/color-support in this repository and push your changes to that branch. I'll move your new commits (if any) to this pull request manually.

And feel free to ask me any questions if something isn't clear to you about my change requests. I'll be glad to explain everything, produce examples or fix some of the issues myself (or even all of them).

For now, I'm awaiting either questions or changes from you. And, again, thanks for your interest in our project, we appreciate it very much! 👍

@ForNeVeR ForNeVeR removed their assignment Jul 16, 2018
@ForNeVeR ForNeVeR self-assigned this Sep 19, 2018
@ForNeVeR
Copy link
Owner Author

ForNeVeR commented Sep 19, 2018

Alright, I'm going to finalize this task based on @B3zaleel's contributions and my comments. Stay tuned.

@ForNeVeR
Copy link
Owner Author

Thanks, everyone! Now this is (finally!) ready for merge.

@ForNeVeR ForNeVeR merged commit 4c1d9e5 into master Oct 20, 2019
@ForNeVeR ForNeVeR deleted the feature/color-support branch October 20, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal for color format
3 participants