updates in methods, related to folder paths

[atherdon]

Is your feature request related to a problem? Please describe.
We have a lot of methods here that work with folder paths or file paths.
my concern is - we can easily broke them, by passing anything else that path related.

1. we need to list here all methods inside of "src" folder files, that somehow related on paths. take your time and ask questions if needed. readme will be helpful as well.
2. when i'll approve step1 - we'll try to avoid bugs at this methods
3. we can also use https://www.npmjs.com/package/is-valid-path for our needs here
4. i think we can create some tests that will show us that we can use anything in arguments on this methods and nothing will go crashing

#13

[atherdon]

@Beni03 @elnur004 let's do this task together.

[elnur004]

@atherdon from which way we need to list methods? may you clarify it a bit, please?

[elnur004]

i've read the readme but it was inexplicit for me

[elnur004]

@atherdon may you explain a bit, please?

[atherdon]

@svr8 can you advise here?

[svr8]

Considering the files inside src folder, we need to find all methods that involve path to folder/file. For example: generateArray method and write methods here work with paths.

[elnur004]

@atherdon i think this is a bit complex task for me, may you change it for me, please?

[atherdon]

@svr8 maybe you can help with this task. first we need to have a list of methods that have paths.
then we'll upgrade them in bulk, because we have same "pain points" there

[svr8]

Here is a list of files:

• fileSystem.js
  • write()
  • read()
  • save()
  • makeFolder()
• generateArray.js
  • setupPath()
• generateFile.js
  • generateFile()
• generateFiles.js
  • generateFiles()
• objects.js
  • combine()
  • split()
• testsMethods.js
  • jsonFileNotEmptyTest()
  • jsonSchemaTest()
• utils.js
  • checkFilePath()
  • isDirectory()
  • fixPath()
  • getFileInfo()
  • getList()
  • getListContent()
  • readAllFiles()
  • fixPath()

[atherdon]

thanks! this is what I need. I'm a bit busy right now. if you need a task - please take a look around and find something.

…

[atherdon]

@IamRaviTejaG check this task and tell me if you think you can improve our methods

[Beni03]

@atherdon
Adding these lines of code in each method will improve them.

1. var isValid = require('is-valid-path');
   //inside each method
2. if(!isValid(path))
   {
   console.log("path is not valid")
   }
   Example:
   //src/fileSystems/write method
   const write = (path, data) => new Promise((resolve) => {
   if(!isValid(path))
   {
   console.log("path is not valid")
   }

const dataStr = stripSymbols(data);

writeFile(path, dataStr, (err) => {
if (err) {
console.error(err);
resolve(false);
} else {
console.info(${path} file generated successfully!);
resolve(true);
}
});
});

[atherdon]

alright - can you open a pull request with code changes so i can look into it?
don't forget your fork, because we made some configuration changes

[Beni03]

Yes! Will sync my fork and send you a pull request

…

Sent from my iPhone

On Sep 5, 2019, at 12:28 AM, Arthur Tkachenko ***@***.***> wrote: alright - can you open a pull request with code changes so i can look into it? don't forget your fork, because we made some configuration changes — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[Beni03]

this is the error I am getting after npm install.
I think because of this error, I could not commit my changes.

[atherdon]

first of all - run audit is not really necessary. because we have 3rd party service that updating packages for us, so i'm pretty confident that audit wouldn't return any major issues. your `npm install` completed without any errors. i think all is working fine. if you want to make a local build, run `npm run build` and you'll see our bundler output

…

[atherdon]

i have a question. i'm a bit confused. we have a method inside of our src folder. named like isFolderExist.
is it work differently from is-valid-path?
should we use both of them or just use only one?

[Beni03]

is-valid-path checks for any invalid characters in the path whereas isFolderExist i.e..(existSync(path)) will check if a folder is already exist. So I think in makeFolder method, it is better if we first use is-valid-path to check for any invalid characters in the path(argument) first and then call the existSync() to see if the folder is already exist or not.

…

On Wed, Sep 11, 2019 at 12:15 AM Arthur Tkachenko ***@***.***> wrote: i have a question. i'm a bit confused. we have a method inside of our src folder. named like isFolderExist. is it work differently from is-valid-path? should we use both of them or just use only one? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#149>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD4BZMZZTRIAFWNUISGKOWTQJCLJNANCNFSM4IDRTWKQ> .

[atherdon]

now it's more clear for me ok show me the code - we'll also add some tests that will help us with catching some bugs

…

[Beni03]

I am geting this error after adding return statement

[atherdon]

can you push your changes and open a pull request, so I can checkout it locally and take a look?

[atherdon]

can you take a look at this task and explore was it completed or not @Edebo ?

[Edebo]

ok