-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update findCsvFiles fn and add pkg.json scripts for parsing csv files #264
Conversation
Code Climate has analyzed commit 6f31e0a and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
@@ -11,6 +11,8 @@ async function findCsvFiles(dirPath) { | |||
|
|||
// eslint-disable-next-line no-shadow | |||
async function helper(dirPath) { | |||
if (dirPath.includes('.json') || dirPath.includes('.md')) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't like these short versions. make it casual
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make it as regex pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
another thing - maybe we dont need a separated file for our new method? because in the end it will be bundles to one file. and tell me if you need help with calling scripts from pkg.json - not sure if you solve it or not |
will merge it and release a new version at npm |
new version released |
I didn't make it in that way I added the same script in every |
show me a code link
|
Btw, this is not what you're trying to do - Looks pretty similar |
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to static food data?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
PR purpose:
1- update findCsvFiles fn
2- create a pkg.json script for every dataset to parse CSV files
3- fix the raw path problem