Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse csv files inside FAO #245

Merged
merged 3 commits into from
Nov 2, 2019
Merged

Conversation

ebrahim-2
Copy link
Contributor

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to static food data?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 1504003 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Nov 2, 2019

Code Climate has analyzed commit a853c07 and detected 0 issues on this pull request.

View more on Code Climate.

@ebrahim-2
Copy link
Contributor Author

now the JSON files are located in the raw folder if you want to parse the inside the data folder there will be a lot of changes in module main functions #240

@atherdon atherdon self-requested a review November 2, 2019 11:32
Copy link
Collaborator

@atherdon atherdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in 5-10 minutes will publish your changes at npm

@atherdon atherdon merged commit 4bb95e4 into Food-Static-Data:master Nov 2, 2019
@atherdon
Copy link
Collaborator

atherdon commented Nov 2, 2019

new version is published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants