This repository has been archived by the owner on Feb 26, 2023. It is now read-only.
Don't create a blank template when parsing templates #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across a bug where using a template in a subdirectory would fail because it was reading an empty template. Here's the task I was using:
Using template.New() created a new, empty-content template with the name "git/user.inc.tmpl".
Afterwards, using .ParseFiles() creates another template with the name "user.inc.tmpl" with my template.
Finally, when .Execute is called, it picked the first, empty template "git/user.inc.tmpl".
This works fine when you don't place templates in subdirectories, as the name you generate matches the name .ParseFiles() does (and therefore gets clobbered with real content).
Using template.ParseTemplate() directly makes the first (and default) template for .Execute the file the user provides.