Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a ServiceManager to shell scripts #1292

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Aug 26, 2024

Issue

When running a shell script, we often need to instantiate a ServiceManager to access services which is repetitive.

Solution and steps

  • Pass by default a ServiceManager as second argument of the script function main.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain mentioned this pull request Aug 26, 2024
14 tasks
@LoicPoullain LoicPoullain merged commit 56c0a81 into v5-0-0 Aug 26, 2024
2 checks passed
@LoicPoullain LoicPoullain deleted the shell-script-services branch August 26, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

1 participant