Merge pull request #1283 from FoalTS/remove-node-fetch

Remove `node-fetch` dependency
FoalTS · Aug 22, 2024 · 5b2d9b0 · 5b2d9b0
2 parents 9044f10 + ed9541a
commit 5b2d9b0
Show file tree

Hide file tree

Showing 12 changed files with 5 additions and 103 deletions.
diff --git a/docs/docs/tutorials/real-world-example-with-react/15-social-auth.md b/docs/docs/tutorials/real-world-example-with-react/15-social-auth.md
@@ -66,7 +66,7 @@ if (!(await verifyPassword(password, user.password))) {
 Now that the password problem is solved, you can install the packages and provide your social credentials in the configuration.
 
 ```bash
-npm install @foal/social node-fetch@2
+npm install @foal/social
 ```
 
 *config/default.json*
@@ -114,7 +114,6 @@ Open the file and add two new routes.
 import { Context, dependency, Get, HttpResponseRedirect } from '@foal/core';
 import { GoogleProvider } from '@foal/social';
 import { User } from '../../entities';
-import * as fetch from 'node-fetch';
 import { Disk } from '@foal/storage';
 
 interface GoogleUserInfo {

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -61,8 +61,7 @@
     "ajv-formats": "~2.1.1",
     "cli-spinner": "~0.2.10",
     "colors": "1.4.0",
-    "commander": "~12.1.0",
-    "node-fetch": "~2.7.0"
+    "commander": "~12.1.0"
   },
   "devDependencies": {
     "@types/mocha": "10.0.7",

diff --git a/packages/cli/src/generate/generators/upgrade/upgrade.ts b/packages/cli/src/generate/generators/upgrade/upgrade.ts
@@ -1,6 +1,3 @@
-// 3p
-import * as fetch from 'node-fetch';
-
 // FoalTS
 import { FileSystem } from '../../file-system';
 import { installDependencies, logger } from '../../utils';

diff --git a/packages/cli/typings/node-fetch/index.d.ts b/packages/cli/typings/node-fetch/index.d.ts
diff --git a/packages/social/package.json b/packages/social/package.json
@@ -52,8 +52,7 @@
     "lib/"
   ],
   "dependencies": {
-    "@foal/core": "^4.5.0",
-    "node-fetch": "~2.7.0"
+    "@foal/core": "^4.5.0"
   },
   "devDependencies": {
     "@types/mocha": "10.0.7",

diff --git a/packages/social/src/abstract-provider.service.ts b/packages/social/src/abstract-provider.service.ts
@@ -4,7 +4,6 @@ import * as crypto from 'crypto';
 
 // 3p
 import { Config, Context, generateToken, HttpResponseRedirect, convertBase64ToBase64url, CookieOptions, HttpResponseOK } from '@foal/core';
-import * as fetch from 'node-fetch';
 
 /**
  * Tokens returned by an OAuth2 authorization server.

diff --git a/packages/social/src/facebook-provider.service.ts b/packages/social/src/facebook-provider.service.ts
@@ -1,9 +1,6 @@
 // std
 import { URL } from 'url';
 
-// 3p
-import * as fetch from 'node-fetch';
-
 // FoalTS
 import { AbstractProvider, SocialTokens } from './abstract-provider.service';
 import { UserInfoError } from './user-info.error';

diff --git a/packages/social/src/github-provider.service.ts b/packages/social/src/github-provider.service.ts
@@ -1,6 +1,3 @@
-// 3p
-import * as fetch from 'node-fetch';
-
 // FoalTS
 import { AbstractProvider, SocialTokens } from './abstract-provider.service';
 import { UserInfoError } from './user-info.error';

diff --git a/packages/social/src/linkedin-provider.service.ts b/packages/social/src/linkedin-provider.service.ts
@@ -1,9 +1,6 @@
 // std
 import { URL } from 'url';
 
-// 3p
-import * as fetch from 'node-fetch';
-
 // FoalTS
 import { AbstractProvider, SocialTokens } from './abstract-provider.service';
 import { UserInfoError } from './user-info.error';

diff --git a/packages/social/src/twitter-provider.service.ts b/packages/social/src/twitter-provider.service.ts
@@ -1,5 +1,3 @@
-// 3p
-import * as fetch from 'node-fetch';
 
 // FoalTS
 import { AbstractProvider, SocialTokens } from './abstract-provider.service';

diff --git a/packages/social/typings/node-fetch/index.d.ts b/packages/social/typings/node-fetch/index.d.ts
-Original file line number
+Diff line change
@@ Expand Up / @@ -4,7 +4,6 @@ import * as crypto from 'crypto'; @@
     // 3p
     import { Config, Context, generateToken, HttpResponseRedirect, convertBase64ToBase64url, CookieOptions, HttpResponseOK } from '@foal/core';
-    import * as fetch from 'node-fetch';
     /**
      * Tokens returned by an OAuth2 authorization server.
@@ Expand Down @@