Enhancements of task form #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 73295f7): https://goal-tracker-app-38cdb--pr47-danny-some-enhanceme-i8fgkrot.web.app (expires Thu, 13 Jun 2024 21:07:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4c4e709ef030d53d132aff41682ebb65bb7a0d4c |
dannymatkovsky
commented
Jun 6, 2024
Comment on lines
-38
to
-40
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Formatter fixes
dannymatkovsky
commented
Jun 6, 2024
Comment on lines
+36
to
+44
| useEffect(() => { | ||
| setDefaultFormValues({ | ||
| name: task.name, | ||
| deadline: task.deadline, | ||
| description: task.description, | ||
| importance: task.importance, | ||
| }); | ||
| }, [task]); | ||
|
|
There was a problem hiding this comment.
Same fix as in #38
dannymatkovsky
commented
Jun 6, 2024
| @@ -4,7 +4,7 @@ export interface Task { | |||
| name: string; | |||
| description: string; | |||
| importance: number; | |||
| deadline: Timestamp; | |||
| deadline: Timestamp | null; | |||
There was a problem hiding this comment.
This prevent formatter from removing optional chaining in task.deadline?.
BlueSkyAndSomeCurses
approved these changes
Jun 6, 2024
BlueSkyAndSomeCurses
merged commit 278f028
into
anton/update-add-form-design
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BlueSkyAndSomeCurses you can merge this PR into your #44 PR.