add test for literal getproperty overwrite #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
approved these changes
Mar 23, 2021
|
Cheers! I don't have merge rights, could you please merge? |
bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
925: add test for literal getproperty overwrite r=DhairyaLGandhi a=mzgubic Another small thing that came from #922 , namely #922 (comment). Writing a separate @adjoint for `literal_getproperty`, which shouldn't be done, passes all tests at the moment. This test will fail if a custom adjoint is written for `literal_getproperty`. @simeonschaub this is from our discussion yesterday Co-authored-by: Miha Zgubic <[email protected]>
|
Build failed: |
|
That can't be related, right? |
|
Hmm, let's try again bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
925: add test for literal getproperty overwrite r=DhairyaLGandhi a=mzgubic Another small thing that came from #922 , namely #922 (comment). Writing a separate @adjoint for `literal_getproperty`, which shouldn't be done, passes all tests at the moment. This test will fail if a custom adjoint is written for `literal_getproperty`. @simeonschaub this is from our discussion yesterday Co-authored-by: Miha Zgubic <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small thing that came from #922 , namely #922 (comment).
Writing a separate @adjoint for
literal_getproperty, which shouldn't be done, passes all tests at the moment. This test will fail if a custom adjoint is written forliteral_getproperty.@simeonschaub this is from our discussion yesterday