Make tests pass on 1.8 #1125
Merged
Make tests pass on 1.8 #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzgubic
reviewed
Nov 25, 2021
test/chainrules.jl
Outdated
Comment on lines
270
to
272
| # broken because Zygoye compresses `(NoTangent(), NoTangent())` into just NoTangent() | ||
| # which ChainRulesTestUtils does not think is valid: | ||
| @test_broken(rrule_via_ad(ZygoteRuleConfig(), round, 2.2) isa Tuple{NoTangent,NoTangent}) |
There was a problem hiding this comment.
The comment would be correct if
Suggested change
| # broken because Zygoye compresses `(NoTangent(), NoTangent())` into just NoTangent() | |
| # which ChainRulesTestUtils does not think is valid: | |
| @test_broken(rrule_via_ad(ZygoteRuleConfig(), round, 2.2) isa Tuple{NoTangent,NoTangent}) | |
| # broken because Zygoye compresses `(NoTangent(), NoTangent())` into just NoTangent() | |
| # which ChainRulesTestUtils does not think is valid: | |
| @test_broken(rrule_via_ad(ZygoteRuleConfig(), round, 2.2)[2](1) isa Tuple{NoTangent,NoTangent}) |
but the rrule should return a y, pb.
In fact it looks fine below, though the rule should probably return ZeroTangent() instead. (Not NoTangent() since we definitely can perturb the input)
(I think we should probably just delete this line?)
There was a problem hiding this comment.
OK, I've deleted it. I was just a bit puzzled by whether this was broken at some point.
test/chainrules.jl
Outdated
Comment on lines
273
to
275
| # Later: That makes no sense, would always be broken. If you call the pullback, | ||
| # then right now Zygote agrees with the rrule, but gives 0.0 not NoTangent: | ||
| rrule_via_ad(ZygoteRuleConfig(), round, 2.2)[2](1) == (NoTangent(), 0.0) |
There was a problem hiding this comment.
doesn't this just use the rrule under the hood anyway?
mzgubic
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
sum(::Tuple)hadcheck_inferred=falsebut NamedTuple did not. Now both do. That was the one failing test.But some other tests marked
check_inferred=falseno longer need that. So perhaps it's a wash.Closes #1066