Skip to content

Commit

Permalink
Merge #856
Browse files Browse the repository at this point in the history 
856: Make PackageCompiler happy r=DhairyaLGandhi a=DhairyaLGandhi



Co-authored-by: Dhairya Gandhi <[email protected]>
Co-authored-by: Dhairya Gandhi <[email protected]>
  • Loading branch information
@bors @DhairyaLGandhi
3 people authored Dec 21, 2020
2 parents b3edf99 + 2346b76 commit 4fdb691
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
8 changes: 6 additions & 2 deletions src/Zygote.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ include("lib/range.jl")
@init @require StatsFuns="4c63d2b9-4356-54db-8cca-17b64c39e42c" include("lib/statsfuns.jl")

# we need to define this late, so that the genfuncs see lib.jl
# Move using statements out of this file to help with sysimage building
using IRTools: varargs!, inlineable!, pis!, slots!
using IRTools.Inner: argnames!, update!
include("compiler/interface2.jl")

include("profiler/Profile.jl")
Expand All @@ -53,11 +56,12 @@ end
@nograd Colors.ColorTypes._parameter_upper_bound
end

precompile() = include(joinpath(@__DIR__, "precompile.jl"))
using InteractiveUtils
precompile() = Requires.@include("precompile.jl")

# helps to work around 265-y issues
function refresh()
include(joinpath(@__DIR__, "compiler/interface2.jl"))
Requires.@include("compiler/interface2.jl")
precompile()
return
end
Expand Down
3 changes: 0 additions & 3 deletions src/compiler/interface2.jl
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
using IRTools: varargs!, inlineable!, pis!, slots!
using IRTools.Inner: argnames!, update!

ignore_sig(T) = all(T -> T <: Type, T.parameters)

function edge!(m::IRTools.Meta, edge::Core.MethodInstance)
Expand Down
2 changes: 0 additions & 2 deletions src/precompile.jl
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
using InteractiveUtils

function pow(x, n)
r = 1
while n > 0
Expand Down

5 comments on commit 4fdb691

@CarloLucibello
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/26713

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.6.0 -m "<description of version>" 4fdb6919273854f79300b491197f97a8d71028e0
git push origin v0.6.0

@DhairyaLGandhi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pushing for a breaking release?

@CarloLucibello
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we removed NNlib's rules

@DhairyaLGandhi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be doing breaking releases without a proper review or when it's not necessary.

In this case, the PR that requests the tag should be relying on a manifest file to run CI, not have a breaking release which can break user code. That makes things feel so much less robust.

Please sign in to comment.