improve performance for pooling in forward mode #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 70.49% 69.74% -0.75%
==========================================
Files 9 9
Lines 583 595 +12
==========================================
+ Hits 411 415 +4
- Misses 172 180 +8
Continue to review full report at Codecov.
|
vchuravy
reviewed
Jan 28, 2019
| @@ -11,7 +11,11 @@ function max_pooling2d_fwd!(x::AbstractArray{T,4}, y::AbstractArray{T,4}, | |||
| hstart = max(hstart, 0) + 1 | |||
| wstart = max(wstart, 0) + 1 | |||
|
|
|||
| y[pw, ph, c, n] = maximum(x[wstart:wend, hstart:hend, c, n]) | |||
There was a problem hiding this comment.
Look at top comment :p. Anyway, to elaborate, the view gets allocated and the loop is super tight so it has terrible performance.
|
Awesome stuff, thanks @KristofferC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87
I tried versions using
views and generators but they were all slow.