Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support for asymmetrical padding #84

Closed
wants to merge 2 commits into from

Conversation

IanButterworth
Copy link
Contributor

Based on discussion at FluxML/Flux.jl#258

@codecov-io
Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #84 into master will increase coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   70.46%   70.84%   +0.37%     
==========================================
  Files           9        9              
  Lines         579      583       +4     
==========================================
+ Hits          408      413       +5     
+ Misses        171      170       -1
Impacted Files Coverage Δ
src/impl/conv.jl 87.58% <100%> (+0.16%) ⬆️
src/NNlib.jl 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085adb7...416cddd. Read the comment docs.

@staticfloat
Copy link
Contributor

I just wanted to quickly note here that although my recently-merged im2col() rewrite has clobbered the diff here, I kept this PR in mind so adapting to the new im2col() should be very easy. Let me know if you have any questions!

@MikeInnes
Copy link
Member

(And apologies for not getting to this earlier -- but it'd be great to get it in!)

@staticfloat
Copy link
Contributor

@ianshmean Thanks for your effort here; I incorporated these changes into my recent overhaul of NNlib, and with FluxML/Flux.jl#718, we have full asymmetric padding support!

@staticfloat staticfloat closed this Apr 9, 2019
@IanButterworth
Copy link
Contributor Author

@staticfloat Great! That makes building out YOLO a lot easier (save the loss functions, which I've not found the time to finish)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants