Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement gelu #83

Merged
merged 1 commit into from
Jan 28, 2019
Merged

implement gelu #83

merged 1 commit into from
Jan 28, 2019

Conversation

chengchingwen
Copy link
Member

Implementation of gaussian error linear unit

@chengchingwen chengchingwen changed the title implment gelu implement gelu Jan 1, 2019
@codecov-io
Copy link

codecov-io commented Jan 1, 2019

Codecov Report

Merging #83 into master will increase coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   70.46%   70.49%   +0.03%     
==========================================
  Files           9        9              
  Lines         579      583       +4     
==========================================
+ Hits          408      411       +3     
- Misses        171      172       +1
Impacted Files Coverage Δ
src/NNlib.jl 100% <ø> (+100%) ⬆️
src/activation.jl 84.21% <50%> (-9.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085adb7...4b4c3a3. Read the comment docs.

test for gelu

fix indent
@chengchingwen
Copy link
Member Author

@MikeInnes Anything I missed?

@MikeInnes
Copy link
Member

👍 Thanks!

@MikeInnes MikeInnes merged commit 09482fb into FluxML:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants