Fix padding causing device to host copies #593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of
pad_reflect
causes input array to be copied to host during backpropagation because of this rule.Instead of usign
StepRange
we should useUnitRange
forselectdim
andreverse
, this avoids expensive copying.Besides copying needlessly, on AMDGPU device to host copy causes synchronization if the memory is unpinned or there is no hardware support for this.
Before:
Now:
Same for
pad_symmetric
:Before:
Now:
PR Checklist