Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AMDGPU compat to 0.5 #521

Merged
merged 6 commits into from
Jul 7, 2023
Merged

Update AMDGPU compat to 0.5 #521

merged 6 commits into from
Jul 7, 2023

Conversation

pxl-th
Copy link
Member

@pxl-th pxl-th commented Jul 7, 2023

  • Don't use artifacts in CI, since 0.5 requires ROCm 5.3+ for which there are no artifacts available.

PR Checklist

  • Tests are added
  • Documentation, if applicable

@pxl-th pxl-th merged commit 91534e1 into master Jul 7, 2023
@pxl-th pxl-th deleted the pxl-th-amdgpu-compat branch July 7, 2023 20:50
@pxl-th
Copy link
Member Author

pxl-th commented Jul 7, 2023

Is it fine if I also tag a release?
Want to update compat for Flux next.

@CarloLucibello
Copy link
Member

Hi Anton, I forgot to mention that the policy in the org for the prominent packages is that those with write access should merge their own PRs, but only after they get an approval from another contributor. Anyways, this PR looks good to me, you can go on and tag a release

@pxl-th
Copy link
Member Author

pxl-th commented Jul 7, 2023

Understood. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants