[NNlibAMDGPUExt] Load MIOpen module only if it is available #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxl-th
changed the title
|
1.6 CUDA failure is probably spurious, but the AMDGPU one does not seem to be. |
|
Segfault in CI, because it uses global ROCm installation which is of incompatible version. |
|
Can we install the MIOpen_jll on CI? |
ToucheSir
reviewed
Mar 31, 2023
.buildkite/pipeline.yml
Outdated
| @@ -76,18 +76,23 @@ steps: | |||
| push!(conf[\"targets\"][\"test\"], \"AMDGPU\"); | |||
| open(io -> TOML.print(io, conf), \"Project.toml\", \"w\"); | |||
| """ | |||
| - julia --project=. -e """ | |||
| using Pkg; | |||
| Pkg.develop(\"AMDGPU\"); | |||
There was a problem hiding this comment.
Another reason to switch to test/Project.toml sooner than later?
|
AMDGPU CI is probably down... |
ToucheSir
reviewed
Apr 1, 2023
|
Should we merge it? Even though AMDGPU CI is down, should be safe to do so. |
3 tasks
ToucheSir
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MIOpen artifact is only available on Julia 1.9 it is not included in AMDGPU by default.
Therefore we need to load it only when it is available.
Otherwise, it causes crashes for users that do not have MIOpen installed.
For example in AMDGPU tests, where we compare CPU with AMDGPU implementations and don't rely on NNlib AMDGPU support.
Project.tomlfor tests.PR Checklist