Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines a
fast_softmax
which uses a low-accuracyfast_exp
. It's about 5x faster on CPU.On a GPU, the low-accuracy
exp
isn't faster at all. For small arrays,fast_softmax
is faster, because it skips theall(isfinite, max_)
check & thus avoids synchronisation. Thus FluxML/NNlibCUDA.jl#63 should get all the benefit.The alternative on CPU is to make an
Array
specialisation using LoopVectorization. That's not as quick as thisfast_exp
(about 2x slower for me) but several more digits of precision. Thisfast_exp
is roughly Float16 precision, do we want that?