add _rng_compat_array
#458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarloLucibello
approved these changes
Jan 7, 2023
ToucheSir
approved these changes
Jan 7, 2023
Co-authored-by: Brian Chen <[email protected]>
ToucheSir
reviewed
Jan 7, 2023
| @@ -62,6 +63,7 @@ dropout!(B::AbstractArray, A::AbstractArray, p::Real; dims = :) = dropout!(_rng_ | |||
| function dropout!(rng::AbstractRNG, dst::AbstractArray, src::AbstractArray, p::Real; dims=:) | |||
| size(dst) == size(src) || throw(DimensionMismatch("dropout! expects output array the same size as input")) | |||
| 0 <= p <= 1 || throw(ArgumentError("dropout expects a probability 0 <= p <= 1")) | |||
| _rng_compat_array(rng, A) | |||
There was a problem hiding this comment.
Suggested change
| _rng_compat_array(rng, A) | |
| _rng_compat_array(rng, src) |
It also occurs to me that the docstring is not in line with the actual function signature. Any reason to use A/B instead of dst/src for the former?
There was a problem hiding this comment.
No real reason, just ended up this way.
|
Sorry, hit the review trigger a little early. Needs some typo fixes to make CI happy. |
|
Done the hacky way in 9425e50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.