Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ctc_loss from Flux to NNlib #426

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Move ctc_loss from Flux to NNlib #426

merged 2 commits into from
Jul 22, 2022

Conversation

mcabbott
Copy link
Member

Copied without changes.

Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass so LGTM. I did notice though that we don't document the CTC loss at all currently 😬. Thoughts on negotiating that if we start moving more loss functions over to NNlib?

@mcabbott
Copy link
Member Author

Didn't look into that... just trying to do the minimal change as step one.

I guess all losses could be moved, but most are just a few lines; this one needs CUDA which is the motivation here.

@mcabbott mcabbott merged commit 023cd3d into FluxML:master Jul 22, 2022
@mcabbott mcabbott deleted the ctc branch July 22, 2022 22:25
@maetshju
Copy link

There is a docstring already for ctc_loss, but it looks like I didn't put a reference for the function in the actual docs anywhere when the PR was merged into Flux. I would be happy to revise the docs for it if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants