Revert LoopVectorization #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 25, 2020 19:09
DhairyaLGandhi
commented
Jul 26, 2020
|
|
||
| # Provide an informative error message if activation functions are called with an array | ||
| for f in (:σ, :hardσ, :logσ, :hardtanh, :relu, :leakyrelu, :relu6, :rrelu, :elu, :gelu, :swish, :lisht, :selu, :celu, :trelu, :softsign, :softplus, :logcosh, :mish, :tanhshrink, :softshrink) | ||
| @eval $(f)(x::AbstractArray, args...) = | ||
| error("Use broadcasting (`", $(string(f)), ".(x)`) to apply activation functions to arrays.") | ||
| end | ||
|
|
||
| for f in (:σ, :tanh) | ||
| @eval Base.broadcasted(::typeof($f), x::Array{T, N}) where {T <: Union{Float64, Float32}, N} = vmap($f, x) |
There was a problem hiding this comment.
This is also some aggressive piracy that is good to get rid of
|
Travis still seems to add LV in the test suite. Any idea why? |
|
Any major changes apart from conflicts needed here? I think it's good to go otherwise. cc @CarloLucibello |
|
ok, let's do this. Then we need some proper discussion on how to reorganize the code in JuliaML |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in FluxML/Flux.jl#1272, #224, it is best to have a better pattern to introduce vectorisation in a more formal manner.
This reverts #199 for the time being.