handle dims properly in gradient of logsoftmax #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
=======================================
Coverage 74.86% 74.86%
=======================================
Files 24 24
Lines 768 768
=======================================
Hits 575 575
Misses 193 193
Continue to review full report at Codecov.
|
|
👍 Thanks! |
bors bot
added a commit
to FluxML/Zygote.jl
that referenced
this pull request
Jan 9, 2020
443: Handle dims keyword argument in softmax adjoint r=MikeInnes a=tanhevg This PR depends on FluxML/NNlib.jl#148 being merged. Once that is done, `Manifest.toml` must be updated. Addresses #425. Co-authored-by: Evgeny Tankhilevich <[email protected]> Co-authored-by: tanhevg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original implementation was not passing
dimstosoftmaxI picked this up when testing gradients for FluxML/Zygote.jl#425