Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ScatterNNlib with NNlib #187

Merged
merged 10 commits into from
Jul 12, 2021
Merged

Replace ScatterNNlib with NNlib #187

merged 10 commits into from
Jul 12, 2021

Conversation

yuehhua
Copy link
Member

@yuehhua yuehhua commented Jul 4, 2021

The functionality of scatter and gather has been migrated to NNlib and NNlibCUDA.

@yuehhua yuehhua merged commit c03577e into master Jul 12, 2021
@yuehhua yuehhua deleted the scatter branch July 12, 2021 03:42
@CarloLucibello
Copy link
Member

It seems many tests have been removed, why?
Also, since the new scatter has different argument ordering, next release should be marked as breaking

@yuehhua
Copy link
Member Author

yuehhua commented Jul 16, 2021

There are two categories of tests are removed:

  1. GATConv layer: tests are removed due to the introduction of number of node/edge check for FeaturedGraph in GraphSignals v0.2 series. Current tests will break the check due to the implementation of GATConv. GATConv has multiple head design, but the GATConv output mix the number of edges and heads together. Thus, GATConv need a new implementation to separate heads and number of edges.
  2. Another test is message-passing network for CUDA: message-passing network has an operation of scalar indexing over a cuarray. Currently, new version of CUDA forbidden the use of scalar indexing, which breaks the tests. Message-passing need a new implementation for indexing vertices or edges, maybe a cuda kernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants