Upgrade warnings for v0.13 #1926
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1926 +/- ##
==========================================
+ Coverage 86.57% 86.63% +0.05%
==========================================
Files 18 18
Lines 1445 1444 -1
==========================================
Hits 1251 1251
+ Misses 194 193 -1
Continue to review full report at Codecov.
|
| end | ||
| size(ŷ,d) == size(y,d) || throw(DimensionMismatch( | ||
| "loss function expects size(ŷ) = $(size(ŷ)) to match size(y) = $(size(y))" | ||
| )) | ||
| end | ||
| end | ||
| _check_sizes(ŷ, y) = nothing # pass-through, for constant label e.g. y = 1 |
There was a problem hiding this comment.
I still wonder if this should go further, BTW, and forbid comparing things which aren't arrays. Things like this:
https://stackoverflow.com/questions/71540612/no-decrease-in-loss-after-lots-traning
|
I would just make them as loud as possible without an error. I feel that the more time you give to update, the less people can complain when they are finally forced to do it. The current set of warnings is just a simple naming issue, there is not reason to force anyone's hand. Something that we decide is plain wrong is candidate for error ASAP. |
|
Happy with the levels here? |
Options for v0.12 deprecations are:
Thoughts on which to do, where?