Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RNN layers accept in => out #1886

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Make RNN layers accept in => out #1886

merged 2 commits into from
Feb 21, 2022

Conversation

mcabbott
Copy link
Member

This does #1658 for all the RNN layers.

@mcabbott mcabbott added the RNN label Feb 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2022

Codecov Report

Merging #1886 (25b4c63) into master (89d5137) will increase coverage by 0.03%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1886      +/-   ##
==========================================
+ Coverage   85.87%   85.91%   +0.03%     
==========================================
  Files          19       19              
  Lines        1430     1434       +4     
==========================================
+ Hits         1228     1232       +4     
  Misses        202      202              
Impacted Files Coverage Δ
src/layers/recurrent.jl 85.54% <80.00%> (ø)
src/deprecations.jl 41.17% <100.00%> (+18.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d5137...25b4c63. Read the comment docs.

src/layers/recurrent.jl Outdated Show resolved Hide resolved
Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcabbott mcabbott merged commit 57ef5c0 into FluxML:master Feb 21, 2022
@mcabbott mcabbott deleted the rnn_pairs branch February 21, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants