Use NNlib.conv_bias_act for Conv #1832
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Xref FluxML/NNlib.jl#346, which adds gradient definitions for |
|
Maybe worth trying to do for v0.13? |
|
Yeah I can take a look tomorrow. What's unclear to me is whether we need some part of the NNlib PR that you linked. Currently, I don't know what code path the gradient takes for CuArrays. |
|
I think there is no gradient defined at all without that PR. It may be close to done though. |
darsnack
force-pushed
the
darsnack/cba
branch
from
74c42fb to
8b5b26a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1302 (supersedes) and fixes #558.
PR Checklist