-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom model example to docs. #1758
Conversation
We should link to other places in the docs that show similar patterns and help new user experiences. Like https://fluxml.ai/tutorials/2020/09/15/deep-learning-flux.html |
Alright, I addressed all your comments. Looks like doctests are failing in basics.md, do you want me to have a look at that as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay. If you're still interested, I think fixing basics.md in a separate PR would be great (to my knowledge, it should be a simple matter of formatting). This is good to go though.
Can we bors this @ToucheSir ? |
I'm wondering if this makes sense as a tutorial in the model zoo. Showing not just the structure based model, but also one that doesn't involve any structure and is very functional. We already have a similar example in the vae model and the cppn etc, but I wonder if an even more basic one is warranted. |
I am personally in favor of a heavier docs page vs model zoo. Currently, it's too much effort to have to go through the model zoo and figure out that you want. Having these in the docs makes it just a bit easier to find |
@logankilpatrick Bors is failing to integrate because of failures on the |
bors r+ |
Build succeeded: |
This PR adds a simple custom model example to the docs. As discussed in Slack, this example would have helped me understand how all the pieces fit together. But, happy to edit/move/delete as desired.
cc @ToucheSir
PR Checklist