Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1706 #1707

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Fix #1706 #1707

merged 1 commit into from
Sep 7, 2021

Conversation

rongcuid
Copy link
Contributor

@rongcuid rongcuid commented Sep 7, 2021 •
edited
Loading

Added qualification for params in docs

Fixes #1706

PR Checklist

  • Entry in NEWS.md
  • Documentation, if applicable

DhairyaLGandhi
DhairyaLGandhi approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@DhairyaLGandhi DhairyaLGandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

bors r+

bors bot added a commit that referenced this pull request Sep 7, 2021
@bors @rongcuid
Merge #1707
d6002ca 
1707: Fix #1706 r=DhairyaLGandhi a=rongcuid

Added qualification for `params` in docs

Fixes #1706 

### PR Checklist

- [ ] Entry in NEWS.md
- [X] Documentation, if applicable


Co-authored-by: Rongcui Dong <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 7, 2021

Timed out.

@DhairyaLGandhi
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 7, 2021

Build succeeded:

@bors bors bot merged commit 9a395b2 into FluxML:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DhairyaLGandhi DhairyaLGandhi DhairyaLGandhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typos in documents
2 participants
@rongcuid @DhairyaLGandhi