Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct eltype and rtol in CrossCor tests #1650

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Use correct eltype and rtol in CrossCor tests #1650

merged 2 commits into from
Jul 2, 2021

Conversation

ToucheSir
Copy link
Member

Ref. #1649.

PR Checklist

  • Tests are added
  • Entry in NEWS.md
  • Documentation, if applicable
  • API changes require approval from a committer (different from the author, if applicable)

darsnack
darsnack previously approved these changes Jul 2, 2021
@darsnack
Copy link
Member

darsnack commented Jul 2, 2021

Let's see CI and then merge.

Copy link
Member

@DhairyaLGandhi DhairyaLGandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment, else lgtm

test/layers/conv.jl Outdated Show resolved Hide resolved
Copy link
Member

@DhairyaLGandhi DhairyaLGandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@darsnack
Copy link
Member

darsnack commented Jul 2, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 2, 2021

Build succeeded:

@bors bors bot merged commit b454024 into FluxML:master Jul 2, 2021
@ToucheSir ToucheSir deleted the bc/conv-crosscor-test branch December 6, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants