Fixup Dataloader's docstring
#1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
previously approved these changes
Jul 2, 2021
| for (x, y) in train_loader # access via tuple destructuring | ||
| @assert size(x) == (10, 5) | ||
| @assert size(y) == (5,) | ||
| # loss += f(x, y) # etc, runs 100 * 20 times |
There was a problem hiding this comment.
Suggested change
| # loss += f(x, y) # etc, runs 100 * 20 times |
|
By the by, the suggestion was to note that the minibatches respect the keys of the named tuple as given in the input dataset. I think it got lost in the GitHub commits. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the Dataloader example into a
jldoctest, and adds a friendly error if you mess up the sizes.DataLoader was exported from Data, but accessible only as (deep breath)
Flux.Data.DataLoaderbecause the module was not imported. I take it that's a mistake, because of the export statement. So I fixed it.Note that
julia> Flux.DataL<tab>still doesn't find it. Perhaps we can murder some sub-modules once the datasets currently residing in Data are removed.(Test failure on nightly ought to be fixed by FluxML/NNlibCUDA.jl#15, but CI gets the old version?)