Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage #89

Closed
andreasnoack opened this issue Oct 18, 2017 · 4 comments · Fixed by #1842
Closed

Coverage #89

andreasnoack opened this issue Oct 18, 2017 · 4 comments · Fixed by #1842
Labels
help wanted

Comments

@andreasnoack
Copy link

andreasnoack commented Oct 18, 2017 •
edited
Loading

It would be great to

  1. Turn on coverage in the Travis script and put the banner in the README.
  2. Improve the coverage. Right now it is around 38% according to Coverage.jl
@ToucheSir
Copy link
Member

Is this still something we want to pursue with GHA/Buildkite?

@CarloLucibello
Copy link
Member

Adding a coverage badge to the readme would be good

@lassepe
Copy link
Contributor

lassepe commented Sep 30, 2021

Seems like this could be closed.

@ToucheSir
Copy link
Member

ToucheSir commented Jan 12, 2022 •
edited
Loading

AFAICT we haven't had code coverage in ~2 years (coinciding with a CI changeover?). I can hopefully have time to look into this in around a month's time, but if anyone wants to jump on it help very much appreciated.

@ToucheSir ToucheSir reopened this Jan 12, 2022
ToucheSir added a commit that referenced this issue Jan 22, 2022
@ToucheSir
Add codecov on CI
dd44520 
Trying to fix #89.
@ToucheSir ToucheSir mentioned this issue Jan 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add codecov on CI FluxML/Flux.jl
6 participants
@andreasnoack @MikeInnes @ToucheSir @CarloLucibello @lassepe @DhairyaLGandhi