Merge #1795

1795: Simplify mse() to use `abs2()` r=DhairyaLGandhi a=staticfloat This simplifies the implementation of `mse()` a bit, as requested by `@DhairyaLGandhi` Co-authored-by: Elliot Saba <[email protected]>
FluxML · Dec 1, 2021 · 638fb1f · 638fb1f
2 parents 8fa4317 + f2998cf
commit 638fb1f
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/losses/functions.jl b/src/losses/functions.jl
@@ -44,8 +44,7 @@ julia> Flux.mse(y_model, y_true)
 """
 function mse(ŷ, y; agg = mean)
   _check_sizes(ŷ, y)
-  error = ŷ .- y
-  real(agg(error .* conj(error)))
+  agg(abs2.(ŷ .- y)))
 end
 
 """