[TASK] Add wmode param to YoutubeViewHelper #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In IE10, IE11 the youtube player ignores its z-index. You need to set this parameter to make the player behave like it’s expected. See http://stackoverflow.com/questions/4050999/youtube-iframe-wmode-issue for further details.
htuscher
force-pushed
the
development
branch
from
a2c4430 to
49aa3f0
Compare
xf-
added a commit
that referenced
this pull request
Feb 25, 2015
[TASK] Add wmode param to YoutubeViewHelper
| @@ -60,6 +60,7 @@ public function initializeArguments() { | |||
| $this->registerArgument('end', 'integer', 'Stop playing after seconds.', FALSE); | |||
| $this->registerArgument('lightTheme', 'boolean', 'Use the YouTube player\'s light theme.', FALSE, FALSE); | |||
| $this->registerArgument('videoQuality', 'string', 'Set the YouTube player\'s video quality (hd1080,hd720,highres,large,medium,small).', FALSE); | |||
| $this->registerArgument('wmode', 'string', 'Set the Window-Mode of the YouTube player (transparent,opaque). This is necessary for z-index handling in IE10/11.', FALSE); | |||
There was a problem hiding this comment.
Should have been named windowMode. Not a single one of the other parameters use a contracted naming so this attribute shouldn't either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IE10, IE11 the youtube player ignores its z-index.
You need to set this parameter to make the player behave like it’s
expected.
See
http://stackoverflow.com/questions/4050999/youtube-iframe-wmode-issue
for further details.