Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add FAL support to image info view helpers #634

Merged
merged 1 commit into from
Jul 24, 2014
Merged

[TASK] Add FAL support to image info view helpers #634

merged 1 commit into from
Jul 24, 2014

Conversation

bjo3rnf
Copy link
Contributor

@bjo3rnf bjo3rnf commented Jul 16, 2014

As requested in #619

@NamelessCoder
Copy link
Member

Please refactor to add two methods getInfoByReferenceUid and getInfoByUid and turn the current getInfo method into a wrapper which calls either of these methods according to ViewHelper parameters.

This will help us create tests for the code.

@bjo3rnf
Copy link
Contributor Author

bjo3rnf commented Jul 17, 2014

Sure thing, force pushed. The other VHs provide the argument src, this one uses path. Should we unify them knowing it is a BC break?

@NamelessCoder
Copy link
Member

The other VHs provide the argument src, this one uses path. Should we unify them knowing it is a BC break?

I vote yes to that - but the change must be recorded as breaking change for the 2.0 release note.

@NamelessCoder
Copy link
Member

Björn would you mind cropping off the last commit and making that as a second PR once this one is merged?

@bjo3rnf
Copy link
Contributor Author

bjo3rnf commented Jul 24, 2014

Sure thing. There you go.

NamelessCoder added a commit that referenced this pull request Jul 24, 2014
[TASK] Add FAL support to image info view helpers
@NamelessCoder NamelessCoder merged commit d69d571 into FluidTYPO3:development Jul 24, 2014
@NamelessCoder
Copy link
Member

Ready for seconds ;)

@bjo3rnf bjo3rnf deleted the falsupport branch July 24, 2014 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants