Per-channel ALL_SOUND_OFF when seeking/stopping player #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
albedozero
commented
Sep 15, 2021
•
albedozero
commented
- Only send all sound off on channels which had notes playing
- Send it as ALL_SOUND_OFF CC to a MIDI router to route it to a different synth channel afterwards
send fluid_synth_all_notes_off instead of fluid_synth_all_sounds_off when seeking the player, as the latter creates audio artifacts by cutting off notes without allowing them to complete their release phase
add an array that can be used to specify which channels to send all_notes_off when stopping or seeking the player
allow sending fluid_synth_all_notes_off on specific channels instead of all channels when seeking or stopping the player, but keep the default behavior of sending on all channels
|
Discussion/explanation in #981 |
MAX_NUMBER_OF_CHANNELS is limit when looping over player->notesoff_channels
put all relevant notes into release phase, regardless of sustain or sostenuto
avoids hanging notes, even when sustain pedal is depressed
This reverts commit 0395e91.
This reverts commit 03c07c4.
This reverts commit cedfb64.
This reverts commit 545f1e9.
add a setting that tells the player whether to call fluid_synth_all_notes_off for all channels when seeking/stopping, or send an ALL_SOUNDS_OFF event on only the channels that have played notes
remove calls to fluid_synth_all_sounds_off when seeking/stopping player and instead send ALL_SOUND_OFF control change event on playing channels
mawe42
reviewed
Sep 20, 2021
use a fluid_list_t to keep track of channels on which the player has sent messages
derselbst
reviewed
Sep 26, 2021
|
Kudos, SonarCloud Quality Gate passed! |
derselbst
changed the title
sykhro
pushed a commit
to sykhro/fluidsynth-pipewire
that referenced
this pull request
Dec 7, 2021
- Only send all sound off on channels which had notes playing - Send it as ALL_SOUND_OFF CC to a MIDI router to route it to a different synth channel afterwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.