Fix interruptions of real-time playback #1494
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2c322d8.
|
spessasus
reviewed
Mar 2, 2025
| fres_diff = fres - iir_filter->last_fres; | ||
| if(iir_filter->filter_startup) | ||
| { | ||
| // The filer was just starting up, make sure to calculate initial coefficients for the initial Q value, even though the fres may not have changed |
There was a problem hiding this comment.
typo: it should be "filter" instead of "filer"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1432 introduced an on-the-fly recalculation of the filter coefficients, whenever the filter parameters change. It turns out this consumes too much CPU for voices that heavily depend on e.g. modulating the IIR filter.
This PR addresses this problem by avoiding direct calls to
sin()andcos()and instead using a lookup table for calculating the filter coefficients.TODO:
fluid_iir_filter_init_table()Fixes #1481