Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address findings from issue #1475 #1486

Merged
merged 4 commits into from
Feb 15, 2025
Merged

Address findings from issue #1475 #1486

merged 4 commits into from
Feb 15, 2025

Conversation

derselbst
Copy link
Member

@derselbst derselbst commented Feb 8, 2025

This addresses the findings of issue #1475, in particular:

  • Update the documentation about the load shell comand
  • Revise error handling of the load shell command
  • Allow drum channels to profit from Bank Offsets by no longer ignoring MSB Bank changes for drum channels (second try after allow bank changes on drum channels #176)
  • Make the preset fallback logic on drum channels more predictable, to migitage my concerns in 883b640. I.e. instead of directly falling back to preset 128:0, we are now falling back to bank 128, while keeping the currently set program. And only if that fails as well, we pick the standard drum kit at 128:0.

@derselbst derselbst merged commit 34711b5 into master Feb 15, 2025
79 checks passed
@derselbst derselbst deleted the 1475 branch February 15, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FluidSynth MIDI player sometimes fails to find presets in SoundFont on bank > 0
1 participant