Implement MSGS-style Drum Note Cut #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
|
I have tested this PR on Doom soundtrack and the drums sound closer to a real Roland SC-55 now. Good job! Comparison between version 2.3.1, this PR and a recording from an SC-55: |
|
Kudos, SonarCloud Quality Gate passed! |
|
+1 to this. It improves playback when using Windows' gm.dls inspired soundfonts, drum note length matches the Microsoft Synthesizer behaviour with this patch. |
|
Thanks for the feedback. Will become part of fluidsynth 2.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the drum note cut used by Microsoft's software synth as discussed in #1196. Whenever a NoteOn is played on a drum channel, any previously playing voice for the same note is now being canceled / cut.
I am not sure if this make musically sense, whether this is permitted by the SF2 spec and whether it breaks any use-case. Any feedback is therefore highly welcome!