Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent samples accidentally having their loops disabled #1018

Merged
merged 2 commits into from
Jan 16, 2022
Merged

Prevent samples accidentally having their loops disabled #1018

merged 2 commits into from
Jan 16, 2022

Conversation

derselbst
Copy link
Member

@derselbst derselbst commented Jan 5, 2022 •
edited
Loading

If a SoundFont sets loopstart == loopend and then uses loop-offset-modulators to fix up those loops assigning them with a valid position, the sample was previously switched to unlooped mode erroneously.

For the long story, see #1017.

@derselbst derselbst added the bug label Jan 5, 2022
@derselbst derselbst mentioned this pull request Jan 5, 2022
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

30.0% 30.0% Coverage
0.0% 0.0% Duplication

@derselbst
Copy link
Member Author

@mawe42 Your comment made me think: I'm now accepting loopstart == loopend without modifications. I print a debug message in this case. And in case we fixed up any other loops due to reasons, there will now be a warning displayed after processing all the samples. I think this should be simple enough to go into 2.2.5

@derselbst derselbst requested a review from mawe42 January 9, 2022 11:07
@derselbst derselbst changed the title Prevent samples accidentially having their loops disabled Prevent samples accidentally having their loops disabled Jan 14, 2022
@derselbst derselbst merged commit e3d8b3f into 2.2.x Jan 16, 2022
@derselbst derselbst deleted the fix1017 branch January 16, 2022 13:35
@derselbst derselbst linked an issue Jan 16, 2022 that may be closed by this pull request
Soundfonts that use loop offsets rather than sample loop points do not loop. #1017
Closed
@DaforLynx DaforLynx mentioned this pull request Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mawe42 mawe42 Awaiting requested review from mawe42

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Soundfonts that use loop offsets rather than sample loop points do not loop.
1 participant
@derselbst