Merge pull request #80 from muukii/muukii/placeholder-label

Use UILabel to display placeholder
FluidGroup · Nov 2, 2019 · 2b530d9 · 2b530d9
2 parents aa9203e + 55d797b
commit 2b530d9
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 33 deletions.
diff --git a/Demo/ViewController.swift b/Demo/ViewController.swift
@@ -40,7 +40,7 @@ class ViewController: UIViewController {
     self.growingTextView.layer.cornerRadius = 4
     self.growingTextView.backgroundColor = UIColor(white: 0.9, alpha: 1)
     self.growingTextView.placeholderAttributedText = NSAttributedString(
-      string: "Placeholder text",
+      string: "Placeholder text Placeholder text Placeholder text",
       attributes: [
         .font: self.growingTextView.textView.font!,
         .foregroundColor: UIColor.gray

diff --git a/NextGrowingTextView.xcodeproj/project.pbxproj b/NextGrowingTextView.xcodeproj/project.pbxproj
@@ -198,6 +198,7 @@
 			developmentRegion = English;
 			hasScannedForEncodings = 0;
 			knownRegions = (
+				English,
 				en,
 				Base,
 			);
@@ -320,7 +321,7 @@
 				SDKROOT = iphoneos;
 				SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
-				SWIFT_VERSION = 4.2;
+				SWIFT_VERSION = 5.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
 				VERSIONING_SYSTEM = "apple-generic";
 				VERSION_INFO_PREFIX = "";
@@ -366,7 +367,7 @@
 				MTL_ENABLE_DEBUG_INFO = NO;
 				SDKROOT = iphoneos;
 				SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
-				SWIFT_VERSION = 4.2;
+				SWIFT_VERSION = 5.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
 				VALIDATE_PRODUCT = YES;
 				VERSIONING_SYSTEM = "apple-generic";

diff --git a/NextGrowingTextView/NextGrowingInternalTextView.swift b/NextGrowingTextView/NextGrowingInternalTextView.swift
@@ -31,11 +31,18 @@ internal class NextGrowingInternalTextView: UITextView {
 
   var didChange: () -> Void = {}
   var didUpdateHeightDependencies: () -> Void = {}
+
+  private lazy var placeholderDisplayLabel = UILabel()
 
   override init(frame: CGRect, textContainer: NSTextContainer?) {
     super.init(frame: frame, textContainer: textContainer)
 
     NotificationCenter.default.addObserver(self, selector: #selector(NextGrowingInternalTextView.textDidChangeNotification(_ :)), name: UITextView.textDidChangeNotification, object: self)
+
+    placeholderDisplayLabel.numberOfLines = 0
+    placeholderDisplayLabel.adjustsFontSizeToFitWidth = true
+    placeholderDisplayLabel.minimumScaleFactor = 0.4
+    addSubview(placeholderDisplayLabel)
   }
 
   required init?(coder aDecoder: NSCoder) {
@@ -71,54 +78,44 @@ internal class NextGrowingInternalTextView: UITextView {
       didUpdateHeightDependencies()
     }
   }
-
+  
   var placeholderAttributedText: NSAttributedString? {
-    didSet {
-      setNeedsDisplay()
+    get {
+      placeholderDisplayLabel.attributedText
+    }
+    set {
+      placeholderDisplayLabel.attributedText = newValue
+      setNeedsLayout()
     }
   }
 
   override func layoutSubviews() {
     super.layoutSubviews()
-    setNeedsDisplay()
-  }
-
-  override func draw(_ rect: CGRect) {
-    super.draw(rect)
-
-    guard displayPlaceholder else { return }
-
-    let paragraphStyle: NSMutableParagraphStyle = NSMutableParagraphStyle()
-    paragraphStyle.alignment = textAlignment
-
-    let targetRect = CGRect(
-      x: 5 + textContainerInset.left,
-      y: textContainerInset.top,
-      width: frame.size.width - (textContainerInset.left + textContainerInset.right),
-      height: frame.size.height - (textContainerInset.top + textContainerInset.bottom)
+
+    let maxSize = bounds.inset(by: textContainerInset).size
+
+    var size = placeholderDisplayLabel.sizeThatFits(maxSize)
+    size.height = min(size.height, maxSize.height)
+
+    placeholderDisplayLabel.frame = CGRect(
+      origin: .init(
+        x: 5 + textContainerInset.left,
+        y: textContainerInset.top
+      ),
+      size: size
     )
 
-    let attributedString = placeholderAttributedText
-    attributedString?.draw(in: targetRect)
   }
 
   // MARK: Private
 
-  private var displayPlaceholder: Bool = true {
-    didSet {
-      if oldValue != displayPlaceholder {
-        setNeedsDisplay()
-      }
-    }
-  }
-
   @objc
   private dynamic func textDidChangeNotification(_ notification: Notification) {
     updatePlaceholder()
     didChange()
   }
 
   private func updatePlaceholder() {
-    displayPlaceholder = text.isEmpty
+    placeholderDisplayLabel.isHidden = !text.isEmpty
   }
 }