Feat: Support Google Cloud Storage #4061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllenFang
force-pushed
the
feat/support-gcs
branch
from
c2500c9 to
e5954cb
Compare
0xi4o
approved these changes
Feb 27, 2025
|
hi @0xi4o boss, hold on.. lol, I found that I missing the logs I will patch this MR in these couple of days🙏 |
|
Ah ok. I will wait for your updates @AllenFang. |
|
hi @0xi4o But after your fix, it seems change a lots (not sure whether it is cause by indent space? |
|
never mind, I get it back and fix the logger part. @0xi4o , please take a look. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi team, I would like to make Flowise to support GCS as one of storage type so please help to me review this PR. I've been tested my work a lots, if you need a demo as the screenshot or screen recording, please let me know.
furthermore, if i'm lucky that this MR could be merged. I will help to refactor the code a bit especially the storageUtil.ts.